GroupV3Test.php 9.5 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268
  1. <?php
  2. use App\Models\GroupInfo;
  3. use App\Models\GroupMember;
  4. use App\Models\Share;
  5. use Illuminate\Foundation\Testing\RefreshDatabase;
  6. use Illuminate\Support\Facades\DB;
  7. use Illuminate\Support\Str;
  8. uses(RefreshDatabase::class);
  9. /**
  10. * v3 团队本身。
  11. *
  12. * 端点:
  13. * GET /api/v3/groups?search= 搜公开团队(登录)
  14. * POST /api/v3/groups 建团队(登录,建的人成为 owner)
  15. * GET /api/v3/groups/{group} 详情(公开团队可不登录;私有团队只有成员)
  16. * PATCH /api/v3/groups/{group} 改信息(owner / manager)
  17. * DELETE /api/v3/groups/{group} 删团队(owner;名下有资源 409)
  18. * GET /api/v3/me/groups?owned=&search= 我创建的 / 我参加的
  19. *
  20. * 这里断言的是形状而非契约(spectator 未安装,见 v3-resource skill 第 3 步)。
  21. */
  22. function makePrivateTeam(): array
  23. {
  24. [$team, $users] = makeTeam();
  25. GroupInfo::where('uid', $team)->update(['status' => GroupInfo::STATUS_PRIVATE]);
  26. return [$team, $users];
  27. }
  28. /* ---------------- 搜公开团队 ---------------- */
  29. it('searches public teams only', function () {
  30. $me = makeStudio('me');
  31. $public = makeGroup(makeStudio('a'), 'pali readers');
  32. $private = makeGroup(makeStudio('b'), 'pali secret');
  33. GroupInfo::where('uid', $private)->update(['status' => GroupInfo::STATUS_PRIVATE]);
  34. makeGroup(makeStudio('c'), 'other');
  35. $data = $this->getJson('/api/v3/groups?search=PALI', authHeader($me))
  36. ->assertOk()
  37. ->json('data');
  38. expect(array_column($data, 'id'))->toBe([$public]);
  39. expect($data[0])->toHaveKeys(['id', 'name', 'description', 'status', 'owner', 'created_at', 'updated_at']);
  40. expect($data[0])->not->toHaveKey('role');
  41. });
  42. it('requires login to search teams', function () {
  43. $this->getJson('/api/v3/groups')->assertUnauthorized();
  44. });
  45. it('does not query per team when searching', function () {
  46. $me = makeStudio('me');
  47. $countQueriesFor = function (int $teams) use ($me): int {
  48. for ($i = 0; $i < $teams; $i++) {
  49. makeGroup(makeStudio('owner-'.Str::random(8)), 'n+1 team '.Str::random(4));
  50. }
  51. DB::flushQueryLog();
  52. DB::enableQueryLog();
  53. $this->getJson('/api/v3/groups?search=n%2B1', authHeader($me))->assertOk();
  54. $count = count(DB::getQueryLog());
  55. DB::disableQueryLog();
  56. return $count;
  57. };
  58. expect($countQueriesFor(8))->toBe($countQueriesFor(1));
  59. });
  60. /* ---------------- 建团队 ---------------- */
  61. it('creates a team with the creator as owner', function () {
  62. $me = makeStudio('me');
  63. $response = $this->postJson('/api/v3/groups', ['name' => '新团队', 'description' => '简介'], authHeader($me))
  64. ->assertCreated()
  65. ->assertJsonPath('data.name', '新团队')
  66. ->assertJsonPath('data.status', GroupInfo::STATUS_PUBLIC)
  67. ->assertJsonPath('data.role', 'owner')
  68. ->assertJsonPath('data.owner.id', $me);
  69. $team = $response->json('data.id');
  70. $member = GroupMember::where('group_id', $team)->where('user_id', $me)->first();
  71. expect($member->role)->toBe('owner');
  72. expect((int) $member->power)->toBe(0);
  73. });
  74. it('rejects a duplicate name under the same owner', function () {
  75. $me = makeStudio('me');
  76. makeGroup($me, 'dup');
  77. $this->postJson('/api/v3/groups', ['name' => 'dup'], authHeader($me))
  78. ->assertUnprocessable()
  79. ->assertJsonValidationErrors('name');
  80. // 别人名下同名不冲突
  81. $this->postJson('/api/v3/groups', ['name' => 'dup'], authHeader(makeStudio('other')))
  82. ->assertCreated();
  83. });
  84. it('validates new teams', function (array $payload, string $field) {
  85. $this->postJson('/api/v3/groups', $payload, authHeader(makeStudio('me')))
  86. ->assertUnprocessable()
  87. ->assertJsonValidationErrors($field);
  88. })->with([
  89. 'missing name' => [[], 'name'],
  90. 'name too long' => [['name' => str_repeat('a', 65)], 'name'],
  91. 'bad status' => [['name' => 'x', 'status' => 20], 'status'],
  92. ]);
  93. it('requires login to create a team', function () {
  94. $this->postJson('/api/v3/groups', ['name' => 'x'])->assertUnauthorized();
  95. });
  96. /* ---------------- 详情 ---------------- */
  97. it('shows a public team to anyone, with the viewer role', function () {
  98. [$team, $users] = makeTeam();
  99. $this->getJson("/api/v3/groups/{$team}")
  100. ->assertOk()
  101. ->assertJsonPath('data.id', $team)
  102. ->assertJsonPath('data.role', null);
  103. $this->getJson("/api/v3/groups/{$team}", authHeader($users['editor']))
  104. ->assertJsonPath('data.role', 'editor');
  105. });
  106. it('hides a private team from outsiders', function () {
  107. [$team, $users] = makePrivateTeam();
  108. $this->getJson("/api/v3/groups/{$team}")->assertForbidden();
  109. $this->getJson("/api/v3/groups/{$team}", authHeader($users['outsider']))->assertForbidden();
  110. $this->getJson("/api/v3/groups/{$team}", authHeader($users['reader']))
  111. ->assertOk()
  112. ->assertJsonPath('data.role', 'reader');
  113. });
  114. it('returns 404 for an unknown team', function () {
  115. $this->getJson('/api/v3/groups/'.Str::uuid())->assertNotFound();
  116. });
  117. /* ---------------- 改团队 ---------------- */
  118. it('lets owners and managers update the team', function (string $actor) {
  119. [$team, $users] = makeTeam();
  120. $this->patchJson("/api/v3/groups/{$team}", ['name' => 'renamed', 'status' => 10], authHeader($users[$actor]))
  121. ->assertOk()
  122. ->assertJsonPath('data.name', 'renamed')
  123. ->assertJsonPath('data.status', 10)
  124. ->assertJsonPath('data.role', $actor);
  125. // 成员记录上冗余的团队名跟着改
  126. expect(GroupMember::where('group_id', $team)->pluck('group_name')->unique()->all())->toBe(['renamed']);
  127. })->with(['owner', 'manager']);
  128. it('only changes the fields sent', function () {
  129. [$team, $users] = makeTeam();
  130. GroupInfo::where('uid', $team)->update(['description' => 'keep me']);
  131. $this->patchJson("/api/v3/groups/{$team}", ['name' => 'renamed'], authHeader($users['owner']))
  132. ->assertOk()
  133. ->assertJsonPath('data.description', 'keep me');
  134. });
  135. it('does not let editors, readers or outsiders update the team', function (string $actor) {
  136. [$team, $users] = makeTeam();
  137. $this->patchJson("/api/v3/groups/{$team}", ['name' => 'hacked'], authHeader($users[$actor]))
  138. ->assertForbidden();
  139. expect(GroupInfo::find($team)->name)->toBe('test team');
  140. })->with(['editor', 'reader', 'outsider']);
  141. it('rejects renaming to a name the owner already uses', function () {
  142. [$team, $users] = makeTeam();
  143. makeGroup($users['owner'], 'taken');
  144. $this->patchJson("/api/v3/groups/{$team}", ['name' => 'taken'], authHeader($users['manager']))
  145. ->assertUnprocessable()
  146. ->assertJsonValidationErrors('name');
  147. });
  148. it('does not register PUT on teams', function () {
  149. [$team, $users] = makeTeam();
  150. $this->putJson("/api/v3/groups/{$team}", ['name' => 'x'], authHeader($users['owner']))
  151. ->assertMethodNotAllowed();
  152. });
  153. /* ---------------- 删团队 ---------------- */
  154. it('lets the owner delete a team with its members and shares', function () {
  155. [$team, $users] = makeTeam();
  156. $share = (new Share)->forceFill([
  157. 'id' => random_int(1, PHP_INT_MAX),
  158. 'res_id' => (string) Str::uuid(),
  159. 'res_type' => 2,
  160. 'cooperator_id' => $team,
  161. 'cooperator_type' => 1,
  162. 'power' => 20,
  163. 'create_time' => time() * 1000,
  164. 'modify_time' => time() * 1000,
  165. ]);
  166. $share->save();
  167. $this->deleteJson("/api/v3/groups/{$team}", [], authHeader($users['owner']))
  168. ->assertNoContent();
  169. expect(GroupInfo::find($team))->toBeNull();
  170. expect(GroupMember::where('group_id', $team)->exists())->toBeFalse();
  171. $this->assertModelMissing($share);
  172. });
  173. it('refuses to delete a team that still owns resources', function () {
  174. [$team, $users] = makeTeam();
  175. makeChannel($team, 'team channel');
  176. $this->deleteJson("/api/v3/groups/{$team}", [], authHeader($users['owner']))
  177. ->assertConflict()
  178. ->assertJsonPath('resources.channel', 1);
  179. expect(GroupInfo::find($team))->not->toBeNull();
  180. });
  181. it('only lets the owner delete a team', function (string $actor) {
  182. [$team, $users] = makeTeam();
  183. $this->deleteJson("/api/v3/groups/{$team}", [], authHeader($users[$actor]))
  184. ->assertForbidden();
  185. expect(GroupInfo::find($team))->not->toBeNull();
  186. })->with(['manager', 'editor', 'outsider']);
  187. /* ---------------- 我的团队:owned / search ---------------- */
  188. it('filters my teams by ownership and name', function () {
  189. $me = makeStudio('me');
  190. $mine = makeGroup($me, 'mine alpha');
  191. $joined = makeGroup(makeStudio('other'), 'joined beta');
  192. addGroupMember($joined, $me);
  193. $ids = fn (string $query) => array_column(
  194. $this->getJson("/api/v3/me/groups{$query}", authHeader($me))->assertOk()->json('data'),
  195. 'id'
  196. );
  197. expect($ids(''))->toEqualCanonicalizing([$mine, $joined]);
  198. expect($ids('?owned=true'))->toBe([$mine]);
  199. expect($ids('?owned=false'))->toBe([$joined]);
  200. expect($ids('?search=BETA'))->toBe([$joined]);
  201. $row = $this->getJson('/api/v3/me/groups?owned=false', authHeader($me))->json('data.0');
  202. expect($row['owner']['id'])->not->toBe($me);
  203. expect($row)->toHaveKeys(['status', 'created_at', 'joined_at']);
  204. $this->getJson('/api/v3/me/groups?owned=true', authHeader($me))->assertJsonPath('meta.total', 1);
  205. });
  206. it('rejects a bad owned filter', function () {
  207. $this->getJson('/api/v3/me/groups?owned=maybe', authHeader(makeStudio('me')))
  208. ->assertUnprocessable()
  209. ->assertJsonValidationErrors('owned');
  210. });