GroupMemberV3Test.php 11 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303
  1. <?php
  2. use App\Models\GroupMember;
  3. use App\Services\V3\GroupAbilityService;
  4. use Illuminate\Foundation\Testing\RefreshDatabase;
  5. use Illuminate\Support\Facades\DB;
  6. use Illuminate\Support\Str;
  7. uses(RefreshDatabase::class);
  8. /**
  9. * v3 团队成员(团队空间的身份与角色)。
  10. *
  11. * 端点:
  12. * GET /api/v3/me/groups 我加入的团队,带我的角色
  13. * GET /api/v3/groups/{group}/members 成员列表(成员可看)
  14. * POST /api/v3/groups/{group}/members 加人(owner / manager)
  15. * PATCH /api/v3/groups/{group}/members/{member} 改角色(owner / manager,owner 行不可改)
  16. * DELETE /api/v3/groups/{group}/members/{member} 移人 / 本人退出(owner 不可)
  17. *
  18. * 这里断言的是形状而非契约(spectator 未安装,见 v3-resource skill 第 3 步)。
  19. */
  20. /* ---------------- 角色推导 ---------------- */
  21. it('derives roles from v2 power when role is empty', function (int $power, string $role) {
  22. $member = (new GroupMember)->forceFill(['power' => $power]);
  23. expect($member->effectiveRole())->toBe($role);
  24. })->with([
  25. 'owner' => [0, 'owner'],
  26. 'manager' => [1, 'manager'],
  27. 'member' => [2, 'reader'],
  28. ]);
  29. it('prefers the role column over power', function () {
  30. $member = (new GroupMember)->forceFill(['power' => 2, 'role' => 'editor']);
  31. expect($member->effectiveRole())->toBe('editor');
  32. });
  33. it('maps roles to abilities', function (string $role, array $allowed) {
  34. foreach (['read', 'create', 'update', 'delete', 'manage_members', 'manage_group', 'delete_group'] as $ability) {
  35. expect(GroupAbilityService::roleAllows($role, $ability))
  36. ->toBe(in_array($ability, $allowed, true), "{$role} / {$ability}");
  37. }
  38. })->with([
  39. 'owner' => ['owner', ['read', 'create', 'update', 'delete', 'manage_members', 'manage_group', 'delete_group']],
  40. 'manager' => ['manager', ['read', 'create', 'update', 'manage_members', 'manage_group']],
  41. 'editor' => ['editor', ['read', 'update']],
  42. 'reader' => ['reader', ['read']],
  43. ]);
  44. it('treats the owner uid itself as full ability and outsiders as none', function () {
  45. [$team, $users] = makeTeam();
  46. $abilities = app(GroupAbilityService::class);
  47. expect($abilities->can($users['owner'], $users['owner'], 'delete'))->toBeTrue();
  48. expect($abilities->can($users['editor'], $team, 'update'))->toBeTrue();
  49. expect($abilities->can($users['editor'], $team, 'create'))->toBeFalse();
  50. expect($abilities->can($users['outsider'], $team, 'read'))->toBeFalse();
  51. });
  52. /* ---------------- GET /me/groups ---------------- */
  53. it('lists my teams with my role', function () {
  54. [$team, $users] = makeTeam();
  55. makeGroup($users['outsider'], 'not mine');
  56. $data = $this->getJson('/api/v3/me/groups', authHeader($users['editor']))
  57. ->assertOk()
  58. ->json('data');
  59. expect($data)->toHaveCount(1);
  60. expect($data[0])->toMatchArray(['id' => $team, 'name' => 'test team', 'role' => 'editor']);
  61. expect($data[0])->toHaveKeys(['description', 'owner_id', 'joined_at']);
  62. expect($data[0]['member_id'])->toBe(memberId($team, $users['editor']));
  63. });
  64. it('requires login for my teams', function () {
  65. $this->getJson('/api/v3/me/groups')->assertUnauthorized();
  66. });
  67. /* ---------------- GET members ---------------- */
  68. it('lets any member list the members', function () {
  69. [$team, $users] = makeTeam();
  70. $data = $this->getJson("/api/v3/groups/{$team}/members", authHeader($users['reader']))
  71. ->assertOk()
  72. ->json('data');
  73. $roles = array_column($data, 'role');
  74. expect(array_slice($roles, 0, 2))->toBe(['owner', 'manager']);
  75. expect(array_slice($roles, 2))->toEqualCanonicalizing(['editor', 'reader']);
  76. expect($data[0])->toHaveKeys(['id', 'group_id', 'role', 'joined_at', 'user']);
  77. expect($data[0]['id'])->toBeString();
  78. expect($data[0]['user']['id'])->toBe($users['owner']);
  79. });
  80. it('hides the member list from outsiders', function () {
  81. [$team, $users] = makeTeam();
  82. $this->getJson("/api/v3/groups/{$team}/members", authHeader($users['outsider']))
  83. ->assertForbidden();
  84. });
  85. it('answers 401 before looking the team up', function () {
  86. // 认证要排在路由模型绑定之前:未登录不该靠 404 / 200 探出团队是否存在
  87. $this->getJson('/api/v3/groups/'.Str::uuid().'/members')->assertUnauthorized();
  88. });
  89. it('returns 404 for an unknown team', function () {
  90. $this->getJson('/api/v3/groups/'.Str::uuid().'/members', authHeader(makeStudio('someone')))
  91. ->assertNotFound();
  92. });
  93. it('does not query per member', function () {
  94. $countQueriesFor = function (int $extra): int {
  95. [$team, $users] = makeTeam();
  96. for ($i = 0; $i < $extra; $i++) {
  97. addGroupMember($team, makeStudio('extra-'.Str::random(8)));
  98. }
  99. DB::flushQueryLog();
  100. DB::enableQueryLog();
  101. $this->getJson("/api/v3/groups/{$team}/members", authHeader($users['reader']))->assertOk();
  102. $count = count(DB::getQueryLog());
  103. DB::disableQueryLog();
  104. return $count;
  105. };
  106. expect($countQueriesFor(10))->toBe($countQueriesFor(0));
  107. });
  108. /* ---------------- POST members ---------------- */
  109. it('lets owners and managers add members, defaulting to reader', function (string $actor) {
  110. [$team, $users] = makeTeam();
  111. $newcomer = makeStudio('newcomer-'.Str::random(6));
  112. $this->postJson("/api/v3/groups/{$team}/members", ['user_id' => $newcomer], authHeader($users[$actor]))
  113. ->assertCreated()
  114. ->assertJsonPath('data.role', 'reader')
  115. ->assertJsonPath('data.user.id', $newcomer);
  116. $row = GroupMember::where('group_id', $team)->where('user_id', $newcomer)->first();
  117. expect($row->role)->toBe('reader');
  118. expect((int) $row->power)->toBe(2);
  119. })->with(['owner', 'manager']);
  120. it('adds a member with a given role and keeps power in sync', function () {
  121. [$team, $users] = makeTeam();
  122. $newcomer = makeStudio('newcomer');
  123. $this->postJson("/api/v3/groups/{$team}/members", ['user_id' => $newcomer, 'role' => 'manager'], authHeader($users['owner']))
  124. ->assertCreated()
  125. ->assertJsonPath('data.role', 'manager');
  126. expect((int) GroupMember::where('user_id', $newcomer)->value('power'))->toBe(1);
  127. });
  128. it('does not let editors, readers or outsiders add members', function (string $actor) {
  129. [$team, $users] = makeTeam();
  130. $newcomer = makeStudio('newcomer');
  131. $this->postJson("/api/v3/groups/{$team}/members", ['user_id' => $newcomer], authHeader($users[$actor]))
  132. ->assertForbidden();
  133. expect(GroupMember::where('user_id', $newcomer)->exists())->toBeFalse();
  134. })->with(['editor', 'reader', 'outsider']);
  135. it('rejects invalid additions', function (array $payload, string $field) {
  136. [$team, $users] = makeTeam();
  137. $payload = array_map(fn ($value) => $value === ':editor' ? $users['editor'] : $value, $payload);
  138. $this->postJson("/api/v3/groups/{$team}/members", $payload, authHeader($users['owner']))
  139. ->assertUnprocessable()
  140. ->assertJsonValidationErrors($field);
  141. })->with([
  142. 'missing user' => [[], 'user_id'],
  143. 'not a uuid' => [['user_id' => 'abc'], 'user_id'],
  144. 'unknown user' => [['user_id' => '00000000-0000-4000-8000-000000000000'], 'user_id'],
  145. 'already a member' => [['user_id' => ':editor'], 'user_id'],
  146. 'owner role' => [['user_id' => '00000000-0000-4000-8000-000000000000', 'role' => 'owner'], 'role'],
  147. ]);
  148. it('requires login to add members', function () {
  149. [$team] = makeTeam();
  150. $this->postJson("/api/v3/groups/{$team}/members", ['user_id' => (string) Str::uuid()])
  151. ->assertUnauthorized();
  152. });
  153. /* ---------------- PATCH members ---------------- */
  154. it('lets managers change roles, including to manager', function () {
  155. [$team, $users] = makeTeam();
  156. $reader = memberId($team, $users['reader']);
  157. $this->patchJson("/api/v3/groups/{$team}/members/{$reader}", ['role' => 'manager'], authHeader($users['manager']))
  158. ->assertOk()
  159. ->assertJsonPath('data.role', 'manager');
  160. $row = GroupMember::find($reader);
  161. expect($row->role)->toBe('manager');
  162. expect((int) $row->power)->toBe(1);
  163. });
  164. it('demotes a v2 manager to editor with power kept at member level', function () {
  165. [$team, $users] = makeTeam();
  166. $manager = memberId($team, $users['manager']);
  167. $this->patchJson("/api/v3/groups/{$team}/members/{$manager}", ['role' => 'editor'], authHeader($users['owner']))
  168. ->assertOk()
  169. ->assertJsonPath('data.role', 'editor');
  170. expect((int) GroupMember::find($manager)->power)->toBe(2);
  171. });
  172. it('never changes the owner row', function () {
  173. [$team, $users] = makeTeam();
  174. $owner = memberId($team, $users['owner']);
  175. $this->patchJson("/api/v3/groups/{$team}/members/{$owner}", ['role' => 'reader'], authHeader($users['manager']))
  176. ->assertForbidden();
  177. expect(GroupMember::find($owner)->effectiveRole())->toBe('owner');
  178. });
  179. it('does not let editors change roles', function () {
  180. [$team, $users] = makeTeam();
  181. $reader = memberId($team, $users['reader']);
  182. $this->patchJson("/api/v3/groups/{$team}/members/{$reader}", ['role' => 'editor'], authHeader($users['editor']))
  183. ->assertForbidden();
  184. });
  185. it('rejects assigning the owner role', function () {
  186. [$team, $users] = makeTeam();
  187. $reader = memberId($team, $users['reader']);
  188. $this->patchJson("/api/v3/groups/{$team}/members/{$reader}", ['role' => 'owner'], authHeader($users['owner']))
  189. ->assertUnprocessable()
  190. ->assertJsonValidationErrors('role');
  191. });
  192. it('returns 404 for a member of another team', function () {
  193. [$team, $users] = makeTeam();
  194. [$otherTeam, $otherUsers] = makeTeam();
  195. $stranger = memberId($otherTeam, $otherUsers['reader']);
  196. $this->patchJson("/api/v3/groups/{$team}/members/{$stranger}", ['role' => 'editor'], authHeader($users['owner']))
  197. ->assertNotFound();
  198. });
  199. it('does not register PUT', function () {
  200. [$team, $users] = makeTeam();
  201. $reader = memberId($team, $users['reader']);
  202. $this->putJson("/api/v3/groups/{$team}/members/{$reader}", ['role' => 'editor'], authHeader($users['owner']))
  203. ->assertMethodNotAllowed();
  204. });
  205. /* ---------------- DELETE members ---------------- */
  206. it('lets managers remove members', function () {
  207. [$team, $users] = makeTeam();
  208. $editor = GroupMember::where('group_id', $team)->where('user_id', $users['editor'])->first();
  209. $this->deleteJson("/api/v3/groups/{$team}/members/{$editor->id}", [], authHeader($users['manager']))
  210. ->assertNoContent();
  211. $this->assertModelMissing($editor);
  212. });
  213. it('lets a reader leave the team', function () {
  214. [$team, $users] = makeTeam();
  215. $reader = GroupMember::where('group_id', $team)->where('user_id', $users['reader'])->first();
  216. $this->deleteJson("/api/v3/groups/{$team}/members/{$reader->id}", [], authHeader($users['reader']))
  217. ->assertNoContent();
  218. $this->assertModelMissing($reader);
  219. });
  220. it('does not let a reader remove someone else', function () {
  221. [$team, $users] = makeTeam();
  222. $editor = memberId($team, $users['editor']);
  223. $this->deleteJson("/api/v3/groups/{$team}/members/{$editor}", [], authHeader($users['reader']))
  224. ->assertForbidden();
  225. });
  226. it('never removes the owner, not even by themselves', function (string $actor) {
  227. [$team, $users] = makeTeam();
  228. $owner = memberId($team, $users['owner']);
  229. $this->deleteJson("/api/v3/groups/{$team}/members/{$owner}", [], authHeader($users[$actor]))
  230. ->assertForbidden();
  231. expect(GroupMember::find($owner))->not->toBeNull();
  232. })->with(['owner', 'manager']);