GroupMemberStoreTest.php 3.3 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687
  1. <?php
  2. use App\Models\GroupMember;
  3. use Illuminate\Foundation\Testing\RefreshDatabase;
  4. uses(RefreshDatabase::class);
  5. /**
  6. * POST /v2/group-member(往团队里加人)的快照测试。
  7. *
  8. * 原实现不校验登录也不校验调用者在团队里的身份,任何人都能把自己加进任意团队,
  9. * 从而拿到共享给该团队的资源权限(库里有两百多条 editor 级的团队共享)。
  10. * 修复只收紧「谁能调」:与同控制器 destroy 同口径,团队的 owner / manager 才能加人;
  11. * 合法请求的响应形状不变——v4 的 AddMember 还在调它。
  12. */
  13. it('lets the team owner add a member', function () {
  14. $owner = makeStudio('owner');
  15. $team = makeGroup($owner);
  16. $friend = makeStudio('friend');
  17. $this->postJson('/api/v2/group-member', ['user_id' => $friend, 'group_id' => $team], authHeader($owner))
  18. ->assertOk()
  19. ->assertJsonPath('ok', true)
  20. ->assertJsonPath('data.user_id', $friend)
  21. ->assertJsonPath('data.group_id', $team)
  22. ->assertJsonPath('data.power', 2)
  23. ->assertJsonPath('data.role', 'member');
  24. expect(GroupMember::where('group_id', $team)->where('user_id', $friend)->value('power'))->toBe(2);
  25. });
  26. it('lets a team manager add a member', function () {
  27. $team = makeGroup(makeStudio('owner'));
  28. $manager = makeStudio('manager');
  29. addGroupMember($team, $manager, 1);
  30. $friend = makeStudio('friend');
  31. $this->postJson('/api/v2/group-member', ['user_id' => $friend, 'group_id' => $team], authHeader($manager))
  32. ->assertJsonPath('ok', true);
  33. expect(GroupMember::where('group_id', $team)->where('user_id', $friend)->exists())->toBeTrue();
  34. });
  35. it('still reports an existing member', function () {
  36. $owner = makeStudio('owner');
  37. $team = makeGroup($owner);
  38. $friend = makeStudio('friend');
  39. addGroupMember($team, $friend);
  40. $this->postJson('/api/v2/group-member', ['user_id' => $friend, 'group_id' => $team], authHeader($owner))
  41. ->assertJsonPath('ok', false)
  42. ->assertJsonPath('message', 'member exists');
  43. });
  44. it('rejects anonymous requests', function () {
  45. $team = makeGroup(makeStudio('owner'));
  46. $intruder = makeStudio('intruder');
  47. $this->postJson('/api/v2/group-member', ['user_id' => $intruder, 'group_id' => $team])
  48. ->assertStatus(401)
  49. ->assertJsonPath('ok', false);
  50. expect(GroupMember::where('group_id', $team)->where('user_id', $intruder)->exists())->toBeFalse();
  51. });
  52. it('does not let outsiders add themselves', function () {
  53. $team = makeGroup(makeStudio('owner'));
  54. $intruder = makeStudio('intruder');
  55. $this->postJson('/api/v2/group-member', ['user_id' => $intruder, 'group_id' => $team], authHeader($intruder))
  56. ->assertStatus(403)
  57. ->assertJsonPath('ok', false);
  58. expect(GroupMember::where('group_id', $team)->where('user_id', $intruder)->exists())->toBeFalse();
  59. });
  60. it('does not let plain members add people', function () {
  61. $team = makeGroup(makeStudio('owner'));
  62. $member = makeStudio('member');
  63. addGroupMember($team, $member);
  64. $outsider = makeStudio('outsider');
  65. $this->postJson('/api/v2/group-member', ['user_id' => $outsider, 'group_id' => $team], authHeader($member))
  66. ->assertStatus(403);
  67. expect(GroupMember::where('group_id', $team)->where('user_id', $outsider)->exists())->toBeFalse();
  68. });