Prechádzať zdrojové kódy

🔒 (api-v13): POST /v2/group-member 加鉴权:只有团队 owner / manager 能加人

原实现既不校验登录、也不校验调用者在团队里的身份,任何人(包括匿名请求)都能
把自己加进任意团队,再借团队拿到共享给它的资源权限(库里有两百多条 editor 级的
团队共享)——属于「会污染数据库数据」,按 CLAUDE.md 铁律 2 第 ② 条直接修 v2。

- 未登录 401;不是该团队 owner / manager 403(与同控制器 destroy 同口径)
- 合法请求的响应形状不变(v4 的 AddMember 还在调),先录快照测试再改
- 顺带:store 补了中文说明与 @bodyParam;tests/Pest.php 加 makeGroup / addGroupMember

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
visuddhinanda 4 dní pred
rodič
commit
4427145b4e

+ 16 - 2
api-v13/app/Http/Controllers/GroupMemberController.php

@@ -75,17 +75,31 @@ class GroupMemberController extends Controller
     }
     }
 
 
     /**
     /**
-     * Store a newly created resource in storage.
+     * 往团队里加一名普通成员。
+     *
+     * 只有该团队的 owner / manager 能调用(与 destroy 同口径)。
+     *
+     * @bodyParam user_id string required 要加入的用户 uid
+     * @bodyParam group_id string required 团队 uid
      *
      *
      * @return Response
      * @return Response
      */
      */
     public function store(Request $request)
     public function store(Request $request)
     {
     {
-        //
+        $currUser = AuthService::current($request);
+        if (! $currUser) {
+            return $this->error(__('auth.failed'), null, 401);
+        }
         $validated = $request->validate([
         $validated = $request->validate([
             'user_id' => 'required',
             'user_id' => 'required',
             'group_id' => 'required',
             'group_id' => 'required',
         ]);
         ]);
+        $callerPower = GroupMember::where('group_id', $validated['group_id'])
+            ->where('user_id', $currUser['user_uid'])
+            ->value('power');
+        if ($callerPower === null || $callerPower >= 2) {
+            return $this->error(__('auth.failed'), null, 403);
+        }
         // 查找重复的项目
         // 查找重复的项目
         if (GroupMember::where('group_id', $validated['group_id'])->where('user_id', $validated['user_id'])->exists()) {
         if (GroupMember::where('group_id', $validated['group_id'])->where('user_id', $validated['user_id'])->exists()) {
             return $this->error('member exists');
             return $this->error('member exists');

+ 87 - 0
api-v13/tests/Feature/GroupMemberStoreTest.php

@@ -0,0 +1,87 @@
+<?php
+
+use App\Models\GroupMember;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+uses(RefreshDatabase::class);
+
+/**
+ * POST /v2/group-member(往团队里加人)的快照测试。
+ *
+ * 原实现不校验登录也不校验调用者在团队里的身份,任何人都能把自己加进任意团队,
+ * 从而拿到共享给该团队的资源权限(库里有两百多条 editor 级的团队共享)。
+ * 修复只收紧「谁能调」:与同控制器 destroy 同口径,团队的 owner / manager 才能加人;
+ * 合法请求的响应形状不变——v4 的 AddMember 还在调它。
+ */
+it('lets the team owner add a member', function () {
+    $owner = makeStudio('owner');
+    $team = makeGroup($owner);
+    $friend = makeStudio('friend');
+
+    $this->postJson('/api/v2/group-member', ['user_id' => $friend, 'group_id' => $team], authHeader($owner))
+        ->assertOk()
+        ->assertJsonPath('ok', true)
+        ->assertJsonPath('data.user_id', $friend)
+        ->assertJsonPath('data.group_id', $team)
+        ->assertJsonPath('data.power', 2)
+        ->assertJsonPath('data.role', 'member');
+
+    expect(GroupMember::where('group_id', $team)->where('user_id', $friend)->value('power'))->toBe(2);
+});
+
+it('lets a team manager add a member', function () {
+    $team = makeGroup(makeStudio('owner'));
+    $manager = makeStudio('manager');
+    addGroupMember($team, $manager, 1);
+    $friend = makeStudio('friend');
+
+    $this->postJson('/api/v2/group-member', ['user_id' => $friend, 'group_id' => $team], authHeader($manager))
+        ->assertJsonPath('ok', true);
+
+    expect(GroupMember::where('group_id', $team)->where('user_id', $friend)->exists())->toBeTrue();
+});
+
+it('still reports an existing member', function () {
+    $owner = makeStudio('owner');
+    $team = makeGroup($owner);
+    $friend = makeStudio('friend');
+    addGroupMember($team, $friend);
+
+    $this->postJson('/api/v2/group-member', ['user_id' => $friend, 'group_id' => $team], authHeader($owner))
+        ->assertJsonPath('ok', false)
+        ->assertJsonPath('message', 'member exists');
+});
+
+it('rejects anonymous requests', function () {
+    $team = makeGroup(makeStudio('owner'));
+    $intruder = makeStudio('intruder');
+
+    $this->postJson('/api/v2/group-member', ['user_id' => $intruder, 'group_id' => $team])
+        ->assertStatus(401)
+        ->assertJsonPath('ok', false);
+
+    expect(GroupMember::where('group_id', $team)->where('user_id', $intruder)->exists())->toBeFalse();
+});
+
+it('does not let outsiders add themselves', function () {
+    $team = makeGroup(makeStudio('owner'));
+    $intruder = makeStudio('intruder');
+
+    $this->postJson('/api/v2/group-member', ['user_id' => $intruder, 'group_id' => $team], authHeader($intruder))
+        ->assertStatus(403)
+        ->assertJsonPath('ok', false);
+
+    expect(GroupMember::where('group_id', $team)->where('user_id', $intruder)->exists())->toBeFalse();
+});
+
+it('does not let plain members add people', function () {
+    $team = makeGroup(makeStudio('owner'));
+    $member = makeStudio('member');
+    addGroupMember($team, $member);
+    $outsider = makeStudio('outsider');
+
+    $this->postJson('/api/v2/group-member', ['user_id' => $outsider, 'group_id' => $team], authHeader($member))
+        ->assertStatus(403);
+
+    expect(GroupMember::where('group_id', $team)->where('user_id', $outsider)->exists())->toBeFalse();
+});

+ 41 - 0
api-v13/tests/Pest.php

@@ -1,6 +1,8 @@
 <?php
 <?php
 
 
 use App\Models\Channel;
 use App\Models\Channel;
+use App\Models\GroupInfo;
+use App\Models\GroupMember;
 use App\Models\Sentence;
 use App\Models\Sentence;
 use App\Models\UserInfo;
 use App\Models\UserInfo;
 use App\Services\AuthService;
 use App\Services\AuthService;
@@ -176,3 +178,42 @@ function makeSentence(string $channelUid, int $book, int $para, int $wordStart,
 
 
     return $sentence;
     return $sentence;
 }
 }
+
+/**
+ * 建一个团队(group),创建者以 owner(power 0)入团,返回 group uid。
+ *
+ * 与 v2 `GroupController@store` 写入的两行一致。
+ */
+function makeGroup(string $ownerUid, string $name = 'test team'): string
+{
+    $uid = (string) Str::uuid();
+    (new GroupInfo)->forceFill([
+        'id' => random_int(1, PHP_INT_MAX),
+        'uid' => $uid,
+        'name' => $name,
+        'owner' => $ownerUid,
+        'create_time' => time() * 1000,
+        'modify_time' => time() * 1000,
+    ])->save();
+    addGroupMember($uid, $ownerUid, 0);
+
+    return $uid;
+}
+
+/**
+ * 把用户加进团队。power:0 owner、1 manager、2 普通成员(v2 口径)。
+ */
+function addGroupMember(string $groupUid, string $userUid, int $power = 2, ?string $role = null): GroupMember
+{
+    $member = new GroupMember;
+    $member->forceFill(array_filter([
+        'id' => random_int(1, PHP_INT_MAX),
+        'user_id' => $userUid,
+        'group_id' => $groupUid,
+        'group_name' => GroupInfo::where('uid', $groupUid)->value('name'),
+        'power' => $power,
+        'role' => $role,
+    ], fn ($value) => $value !== null))->save();
+
+    return $member;
+}